-
Notifications
You must be signed in to change notification settings - Fork 945
Add Device Support : Tuya TS0601 - TZE200_81isopgh - Garden Watering System #1560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pull Request Test Coverage Report for Build 2352554713
💛 - Coveralls |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1560 +/- ##
==========================================
+ Coverage 80.31% 80.37% +0.05%
==========================================
Files 227 228 +1
Lines 6773 6803 +30
==========================================
+ Hits 5440 5468 +28
- Misses 1333 1335 +2 ☔ View full report in Codecov by Sentry. |
|
Code in this PR looks suspiciously similar #1450 |
javicalle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a little change to go.
javicalle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Thanks Simon. Pretty nice work. |
"sensors has unit L which is unsupported for device_class energy"
|
I had to make a change and remove the metering cluster because the SmartEnergy purpose is for Energy in kW and not in L |
|
Can you add back the metering and just add a constant attribute for unit of measurement |
Does the device measure total sum used or instant demand (flow rate in this case) |
Should be the total sum (should because my device has hardware issue so I cannot test it, always at 0) |
I reverted to to previous version that already has the constant attribute. |
|
Yep I’ll look at that part |
|
@simonbaudart , with all threads related to this Garden Watering Valve, I have difficulties identifying latest code and qwirk. Do you know where is the latest? From discussions, it looks to be finalized, but doesn't seem to have been integrated into any release of ZHA since the time it was closed. Any help would be welcome. Thanks |
closes #1556
One question: I used a "FlowMeasurement" to report a Volume of water consumed.
Is this right ? Or should I use something else ?