Skip to content

Conversation

@simonbaudart
Copy link
Contributor

@simonbaudart simonbaudart commented May 12, 2022

closes #1556

One question: I used a "FlowMeasurement" to report a Volume of water consumed.
Is this right ? Or should I use something else ?

@coveralls
Copy link

coveralls commented May 12, 2022

Pull Request Test Coverage Report for Build 2352554713

  • 21 of 21 (100.0%) changed or added relevant lines in 1 file are covered.
  • 124 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.06%) to 80.376%

Files with Coverage Reduction New Missed Lines %
zhaquirks/tuya/mcu/init.py 2 98.06%
zhaquirks/tuya/init.py 122 71.98%
Totals Coverage Status
Change from base Build 2282780395: 0.06%
Covered Lines: 5468
Relevant Lines: 6803

💛 - Coveralls

@codecov-commenter
Copy link

codecov-commenter commented May 12, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.37%. Comparing base (b802c1f) to head (42ecbf7).
Report is 609 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1560      +/-   ##
==========================================
+ Coverage   80.31%   80.37%   +0.05%     
==========================================
  Files         227      228       +1     
  Lines        6773     6803      +30     
==========================================
+ Hits         5440     5468      +28     
- Misses       1333     1335       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rforro
Copy link
Contributor

rforro commented May 14, 2022

Code in this PR looks suspiciously similar #1450

Copy link
Collaborator

@javicalle javicalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a little change to go.

Copy link
Collaborator

@javicalle javicalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@javicalle
Copy link
Collaborator

Thanks Simon. Pretty nice work.

@javicalle javicalle added the needs final review PR is ready for a final review from a maintainer label May 16, 2022
"sensors has unit L which is unsupported for device_class energy"
@simonbaudart
Copy link
Contributor Author

I had to make a change and remove the metering cluster because the SmartEnergy purpose is for Energy in kW and not in L
Error from HA : "WARNING (Recorder) [homeassistant.components.sensor.recorder] sensor.arrosage_smartenergy_metering_summation_delivered has unit L which is unsupported for device_class energy"

@dmulcahey
Copy link
Collaborator

Can you add back the metering and just add a constant attribute for unit of measurement

@dmulcahey
Copy link
Collaborator

I had to make a change and remove the metering cluster because the SmartEnergy purpose is for Energy in kW and not in L
Error from HA : "WARNING (Recorder) [homeassistant.components.sensor.recorder] sensor.arrosage_smartenergy_metering_summation_delivered has unit L which is unsupported for device_class energy"

Does the device measure total sum used or instant demand (flow rate in this case)

@simonbaudart
Copy link
Contributor Author

I had to make a change and remove the metering cluster because the SmartEnergy purpose is for Energy in kW and not in L
Error from HA : "WARNING (Recorder) [homeassistant.components.sensor.recorder] sensor.arrosage_smartenergy_metering_summation_delivered has unit L which is unsupported for device_class energy"

Does the device measure total sum used or instant demand (flow rate in this case)

Should be the total sum (should because my device has hardware issue so I cannot test it, always at 0)

@simonbaudart
Copy link
Contributor Author

Can you add back the metering and just add a constant attribute for unit of measurement

I reverted to to previous version that already has the constant attribute.
I think this is more a HA change to be done to manage the L.

@dmulcahey
Copy link
Collaborator

Yep I’ll look at that part

@dmulcahey dmulcahey merged commit ef15d4d into zigpy:dev May 23, 2022
@Gilles2senior
Copy link

@simonbaudart , with all threads related to this Garden Watering Valve, I have difficulties identifying latest code and qwirk. Do you know where is the latest? From discussions, it looks to be finalized, but doesn't seem to have been integrated into any release of ZHA since the time it was closed. Any help would be welcome. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs final review PR is ready for a final review from a maintainer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Device Support Request] Tuya TS0601 - TZE200_81isopgh - Garden Watering System

7 participants