Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZSP v14 #631

Merged
merged 35 commits into from
Jul 20, 2024
Merged

EZSP v14 #631

merged 35 commits into from
Jul 20, 2024

Conversation

puddly
Copy link
Contributor

@puddly puddly commented Jun 19, 2024

This is going to be a huge change. Very WIP, only backup and restore is working.

@puddly
Copy link
Contributor Author

puddly commented Jul 17, 2024

This PR is in a state to be able to run successfully on my home network.

However, EmberZNet 8.0.0.0 is completely broken:

  1. LQI and RSSI just do not contain valid values for any packet.
  2. Unicast performance is abysmal and most sends do not succeed once more than a few packets have been sent at once.

This PR needs to be merged so that universal-silabs-flasher can enter the bootloader to downgrade from 8.0.0.0 but I'm otherwise not going to investigate EmberZNet 8.0.0.0 further.

Copy link

codecov bot commented Jul 17, 2024

Codecov Report

Attention: Patch coverage is 99.08676% with 4 lines in your changes missing coverage. Please review.

Project coverage is 99.38%. Comparing base (3657cf3) to head (52dae0b).

Files Patch % Lines
bellows/zigbee/application.py 92.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #631      +/-   ##
==========================================
- Coverage   99.72%   99.38%   -0.34%     
==========================================
  Files          75       79       +4     
  Lines        5017     5047      +30     
==========================================
+ Hits         5003     5016      +13     
- Misses         14       31      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@puddly
Copy link
Contributor Author

puddly commented Jul 20, 2024

Project coverage shrinks just a little bit with this PR but unfortunately there's no sensible way to actually deal with EZSP v14 command processing without rewriting all EZSP commands to use named parameters.

@puddly puddly marked this pull request as ready for review July 20, 2024 14:36
@puddly puddly merged commit c763b6b into zigpy:dev Jul 20, 2024
12 of 14 checks passed
@Hedda
Copy link
Contributor

Hedda commented Jul 23, 2024

Also see comments by Zigbee2MQTT/zigbee-herdsman ember developer Nerivec in SiliconLabs/simplicity_sdk#13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants