Skip to content

Fix test cases for stage2. #9270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 1, 2021
Merged

Conversation

mathetake
Copy link
Contributor

@mathetake mathetake commented Jul 1, 2021

Currently CI is failing on master branch because I think I should have changed this in #9178 where I added one line in start.zig

cc @andrewrk

Unexpected error:
================================================================================
start.zig:86:9: error: struct 'test_case.test_case' has no member named 'main'
================================================================================
Expected error not found:
================================================================================
:85:9: error: struct 'test_case.test_case' has no member named 'main'
================================================================================

Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
@andrewrk
Copy link
Member

andrewrk commented Jul 1, 2021

Thanks for the follow-up. Apologies for that brittle test. @mikdusan already implemented a solution to address this in the test harness elsewhere, but I didn't get around to adapting the solution to stage2 tests.

@andrewrk andrewrk merged commit d606811 into ziglang:master Jul 1, 2021
@mathetake mathetake deleted the fix-stage2-test branch July 1, 2021 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants