In std.process.ArgIteratorWindows, don't treat unclosed quotes like they're escaped#5667
Merged
andrewrk merged 2 commits intoziglang:masterfrom Jun 23, 2020
Merged
Conversation
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, if
std.process.ArgIteratorWindows's argument parser sees a quotation mark that doesn't have a corresponding closing quote, it acts like it's escaped. For example,a b "c dis parsed as four arguments:a,b,"c,d.This PR removes this behavior, so
a b "c dis instead parsed as three arguments:a,b,c d. This better matches the way other Windows commands parse arguments---TYPE "a b.txtprints the contents of a file calleda b.txt---and the wayCommandLineToArgvWworks. This also makesArgIteratorWindowsa little simpler/faster since it no longer needs to count the total number of quotation marks in the command line.(It's possible the current behavior was introduced because if you pass a string like
ab"cdtoCommandLineToArgvW, the returned string includes the quotation mark. But I think this is because of a different oddity inCommandLineToArgvW-- see #2222 (comment) -- and it doesn't happen if you pass a string likea b"cdthat has a space somewhere before the quotation mark.)