enhance fetchPut documentation #24268
Open
+2
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working with the hash map's
fetchPut
function, I encountered a double free issue. Here's the relevant code:Later, when destroying the map, I used:
This caused a double free error because it's not clearly documented that the
key
passed tofetchPut
is not used when an entry with the same key already exists. The original key is retained, and the new one must be freed manually in that case. I missed this detail, leading to the key being freed twice: once in the overwrite logic, and again during map destruction.