x86_64: increase passing test coverage on windows #24193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobly0
force-pushed
the
x86_64-spring-cleaning
branch
4 times, most recently
from
677f28c to
62d4855
Compare
e.g. `x86_64-windows.win10...win11_dt-gnu` -> `x86_64-windows-gnu` When the OS version is the default this is redundant with checking the default in the standard library.
This struct is larger than 256 bytes and code that copies it consistently shows up in profiles of the compiler.
jacobly0
force-pushed
the
x86_64-spring-cleaning
branch
from
62d4855 to
585e418
Compare
jacobly0
force-pushed
the
x86_64-spring-cleaning
branch
from
585e418 to
d44b7e9
Compare
This is not meant to be a long-term solution, but it's the easiest thing to get working quickly at the moment. The main intention of this hack is to allow more tests to be enabled. By the time the coff linker is far enough along to be enabled by default, this will no longer be required.
Now that codegen has no references to linker state this is much easier. Closes ziglang#24153
jacobly0
force-pushed
the
x86_64-spring-cleaning
branch
from
d44b7e9 to
1f98c98
Compare
leecannon
added a commit
to zigtools/zls
that referenced
this pull request
Jun 22, 2025
Parameter changed in ziglang/zig@9176408 of ziglang/zig#24193
leecannon
added a commit
to zigtools/zls
that referenced
this pull request
Jun 22, 2025
Parameter changed in ziglang/zig@9176408 of ziglang/zig#24193
Techatrix
pushed a commit
to zigtools/zls
that referenced
this pull request
Jun 22, 2025
Parameter changed in ziglang/zig@9176408 of ziglang/zig#24193
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that codegen has no references to linker state this is much easier.
Closes #24153