Sema: fix pointers to comptime fields of comptime-known aggregate pointers #23263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlugg
force-pushed
the
comptime-field-ptr
branch
from
9c395c5 to
f3a69b1
Compare
mlugg
force-pushed
the
comptime-field-ptr
branch
from
752e376 to
3e69186
Compare
Turns out the backend currently never emits a non-static initializer, but the handling is kept in case it is needed again in the future.
mlugg
force-pushed
the
comptime-field-ptr
branch
from
3e69186 to
029cc06
Compare
`writeCValue` already emits a cast; including another here is, in fact, invalid, and emits errors under MSVC. Probably this code was originally added to work around the incorrect `.Initializer` location which was fixed in the previous commit.
alexrp
pushed a commit
that referenced
this pull request
May 4, 2025
Sema: fix pointers to comptime fields of comptime-known aggregate pointers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #23190