std.zig.system: remove assert that inspected path is absolute #22568
Conversation
It can also have relative path if PATH has relative path, so just run it with `cwd`. Also it can be a relative shebang path (which is not handled yet) and it's better to skip it rather than crash compiler. Resolves ziglang#22566 Signed-off-by: Eric Joldasov <bratishkaerik@landless-city.net>
| // for simplicity we are assuming it is an absolute path. | ||
| // It can also be a relative path from PATH environment variable. |
There was a problem hiding this comment.
"we are assuming it is an absolute path"
"it can be a relative path"
these are contradictory statements. Can you either make the comment accurate or delete it?
There was a problem hiding this comment.
I wanted to mean here "assume interpreter path is absolute, and handle both absolute and relative for PATH", if it's not clear I can rewrite it
There was a problem hiding this comment.
It's pretty confusing, but, it's OK. Better to fix the regression now.
edit: I changed my mind, I will revert the other commit for now. Let us scrutinize the change more carefully because I do not think relative path is valid here. It is relative to the cwd on the next line.
There was a problem hiding this comment.
edit: I changed my mind, I will revert the other commit for now.
OK
Let us scrutinize the change more carefully because I do not think relative path is valid here. It is relative to the cwd on the next line.
It is valid for PATH cases because they are also evaluted from the point of cwd, and for interpreters I'll try to write version which handles relative path too since work is redone anyway.
…v-in-path" It caused an assertion failure when building Zig from source. This reverts commit 0595feb, reversing changes made to 744771d. closes ziglang#22566 closes ziglang#22568
Followup to #21540
It can also have relative path if PATH has relative path, so just run it with
cwd. Also it can be a relative shebang path (which is not handled yet) and it's better to skip it rather than crash compiler.Resolves #22566