Skip to content

std.posix: Make sigaction() infallible #20706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 23, 2024
Merged

Conversation

alexrp
Copy link
Member

@alexrp alexrp commented Jul 21, 2024

See commit messages for justification.

Closes #20704.

@alexrp alexrp force-pushed the sigaction-nosys branch 2 times, most recently from 3cb187b to 7d3321e Compare July 21, 2024 13:04
alexrp added 2 commits July 21, 2024 22:38
I know of no "POSIX" system that does not have a sigaction() syscall.

Closes ziglang#20704.
…ammer error.

The set of signals that cannot have their action changed is documented in POSIX,
and any additional, non-standard signals are documented by the specific OS. I
see no valid reason why EINVAL should be considered an unpredictable error here.
@alexrp alexrp force-pushed the sigaction-nosys branch from 7d3321e to 2cced89 Compare July 21, 2024 20:39
@andrewrk andrewrk added standard library This issue involves writing Zig code for the standard library. release notes This PR should be mentioned in the release notes. labels Jul 23, 2024
@andrewrk andrewrk merged commit 718f8d5 into ziglang:master Jul 23, 2024
10 checks passed
@alexrp alexrp deleted the sigaction-nosys branch July 23, 2024 18:54
linusg added a commit to linusg/zigline that referenced this pull request Jul 24, 2024
alimpfard pushed a commit to alimpfard/zigline that referenced this pull request Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release notes This PR should be mentioned in the release notes. standard library This issue involves writing Zig code for the standard library.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

std.posix should probably not pretend that sigaction can actually be missing
3 participants