std.Build.Step: make result returning correctly with evalZigProcess #19922
+5
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Atomk
reviewed
May 10, 2024
RossComputerGuy
force-pushed
the
fix/expected-error-build
branch
2 times, most recently
from
f4d9336 to
32d5425
Compare
andrewrk
requested changes
Aug 24, 2024
|
@andrewrk Done, I'll resolve conflicts tonight as well. |
Fixes ziglang#18941 by moving the "checkCompileErrors" call from Build.Step.Compile to Build.Step and returning result if the errors match as expected.
RossComputerGuy
force-pushed
the
fix/expected-error-build
branch
from
32d5425 to
b834777
Compare
|
It isn't obvious to me why this fixes #18941. Can you elaborate? |
|
I don't remember since this PR is from like almost a year ago. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18941 by moving the
checkCompileErrorscall fromBuild.Step.CompiletoBuild.Stepand returning result if the errors match as expected.Continued from #18943
Tested by building https://github.com/MidstallSoftware/apparmor.zig/tree/4f32b90f540769d37879e23cb85e0e1c4fb10dcb