Skip to content

std.heap: add runtime safety for calling stackFallback(N).get multiple times #18275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 10, 2024
Merged

std.heap: add runtime safety for calling stackFallback(N).get multiple times #18275

merged 1 commit into from
Jan 10, 2024

Conversation

@Vexu
Copy link
Member

@Vexu Vexu commented Dec 13, 2023

Closes #16344

@Vexu Vexu added breaking Implementing this issue could cause existing code to no longer compile or have different behavior. standard library This issue involves writing Zig code for the standard library. labels Dec 13, 2023
@Vexu Vexu mentioned this pull request Dec 13, 2023
Closed
IntegratedQuantum
IntegratedQuantum reviewed Dec 13, 2023
View reviewed changes
@Vexu Vexu force-pushed the stack branch 2 times, most recently from a4d62f2 to a4a6e49 Compare December 13, 2023 22:45
@Vexu Vexu removed the breaking Implementing this issue could cause existing code to no longer compile or have different behavior. label Dec 14, 2023
@Vexu Vexu changed the title StackFallBackAllocator: remove helper function reduce risk of footgun std.heap: add runtime safety for calling stackFallback(N).get multiple times Dec 14, 2023
@Vexu Vexu changed the title std.heap: add runtime safety for calling stackFallback(N).get multiple times std.heap: add runtime safety for calling stackFallback(N).get multiple times Dec 14, 2023
@andrewrk
Copy link
Member

andrewrk commented Jan 10, 2024

Nice

@andrewrk andrewrk merged commit 828d239 into ziglang:master Jan 10, 2024
@Vexu Vexu deleted the stack branch January 10, 2024 11:48
@Techatrix Techatrix mentioned this pull request Jan 11, 2024
Merged
@Ratakor Ratakor mentioned this pull request Aug 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@IntegratedQuantum IntegratedQuantum IntegratedQuantum left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

standard library This issue involves writing Zig code for the standard library.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Using StackFallbackAllocator.get() multiple times is a footgun.

3 participants

@Vexu @andrewrk @IntegratedQuantum