elf: report errors for some detected malformed object contents #18207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng object/archive
24 tasks
…paths when found errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18205
Although it fixes the above issue, it's just the beginning of proper error handling in the linker. I will be adding better error catching and reporting incrementally as it's quite an involved task.
This PR also addresses a latent bug in writing a static library when one source is incrementally compiled Zig source - an example of this could be generating
libcompiler_rt.awithout LLVM. The bug would incorrectly calculate the total size of the incrementally compiled Zig source and thus it would fail to correctly re-encode it in the output archive file.