zig build: change "-Drelease" to "-Doptimize" #15192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
motiejus
force-pushed
the
build-release
branch
2 times, most recently
from
6e6af52 to
6c65d9c
Compare
motiejus
commented
Apr 6, 2023
motiejus
force-pushed
the
build-release
branch
3 times, most recently
from
b383f2d to
e2888bb
Compare
motiejus
added a commit
to motiejus/zig
that referenced
this pull request
Apr 7, 2023
Following @Luukdegram's comment[1]: > The default should remain Debug when unspecified. In ReleaseSmall the > user would lose all DWARF support when testing their WebAssembly code. > Building a release version should be opt-in, not the default. [1]: ziglang#15192 (comment)
motiejus
force-pushed
the
build-release
branch
2 times, most recently
from
1a4bee2 to
a23dd8f
Compare
motiejus
added a commit
to motiejus/zig
that referenced
this pull request
Apr 11, 2023
Following @Luukdegram's comment[1]: > The default should remain Debug when unspecified. In ReleaseSmall the > user would lose all DWARF support when testing their WebAssembly code. > Building a release version should be opt-in, not the default. [1]: ziglang#15192 (comment)
motiejus
added a commit
to motiejus/zig
that referenced
this pull request
Apr 11, 2023
Following @Luukdegram's comment[1]: > The default should remain Debug when unspecified. In ReleaseSmall the > user would lose all DWARF support when testing their WebAssembly code. > Building a release version should be opt-in, not the default. [1]: ziglang#15192 (comment)
I find myself quite often creating ReleaseSafe builds and putting them to production for certain experiments: - Debug info are for stack traces. An ongoing example where those would help is ziglang#14815. - Safety checks would have saved a couple of mine and @kubkon's hours in ziglang#15098. This is a breaking change for scripts that make Zig releases -- I will submit another PR to zig-bootstrap and release-cutter after this is merged.
Following @Luukdegram's comment[1]: > The default should remain Debug when unspecified. In ReleaseSmall the > user would lose all DWARF support when testing their WebAssembly code. > Building a release version should be opt-in, not the default. [1]: ziglang#15192 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I find myself quite often creating ReleaseSafe builds and putting them to production for certain experiments:
This is a breaking change for scripts that make Zig releases -- I will submit another PR to zig-bootstrap and release-cutter if/after this is merged.