Repository navigation
Fix incorrect SHA-3 computation with the streaming API - #14852
Merged
Merged
Conversation
Leftover bytes should be added to the buffer, not to the state. (or, always to the state; we can and probably should eventually get rid of the buffer) Fixes ziglang#14851
jedisct1
enabled auto-merge (squash)
March 8, 2023 21:57
truemedian
pushed a commit
to truemedian/zig
that referenced
this pull request
Mar 30, 2023
* Fix SHA3 with streaming Leftover bytes should be added to the buffer, not to the state. (or, always to the state; we can and probably should eventually get rid of the buffer) Fixes ziglang#14851 * Add a test for SHA-3 with streaming
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14851
Also add a test for this.