Missing CommonCrypto/CommonCrypto.h

[lodinukal]

Zig Version

0.15.0-dev.465+bb79c85cb

Steps to Reproduce and Observed Behavior

When trying to compile libgit2, I get

C:\Users\-\AppData\Local\zig\p\N-V-__8AAJbmLwHHxHDWkz0i6WIR6FpNe6tXSLzaPuWtvBBg\deps/ntlmclient/crypt_commoncrypto.c:16:10: error: 'CommonCrypto/CommonCrypto.h' file not found
#include <CommonCrypto/CommonCrypto.h>
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Upon searching for the CommonCrypto.h header in the zig libc for macos, it isn't there (https://github.com/ziglang/zig/tree/master/lib/libc/include/any-macos-any/CommonCrypto)

Expected Behavior

I expected CommonCrypto/CommonCrypto.h to be included in zig's bundled macos libc.

[lodinukal]

The other headers I also expect to be there are found here: https://github.com/Apple-FOSS-Mirror/CommonCrypto/tree/master/CommonCrypto

[alexrp]

Are the functions declared in this header implemented in libSystem? Note that we don't ship any of Apple's other frameworks, just libc.

[alexrp]

Are the functions declared in this header implemented in libSystem?

Looks like it.

I think we just need a refresh of our macOS headers with this line changed to #include <CommonCrypto/CommonCrypto.h> :

zig/tools/macos-headers.c

Line 180 in f0feda8

#include <CommonCrypto/CommonDigest.h>

(CommonCrypto.h includes all the other headers.)

cc @mikdusan