Skip to content

Fix return type error when running incremental on first time ETL. #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix return type error when running incremental on first time ETL. #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/DbLoader.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,6 +306,6 @@ public function getIncrementalLastValue(): string
->whereNotNull($this->updateColumn)
->orderByDesc($this->updateColumn)
->limit(1)
->value($this->updateColumn);
->value($this->updateColumn) ?? '';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make more sense to return null|string ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely. I considered that, but hoped for this to cause the least amount of disruption. The if ($incremental) check correctly fails on an empty string, so everything else downstream runs correctly.

We could change the return type, but that would require additional refactors elsewhere and a version bump for anyone who might be using it (which is only us based on the repos I have access to, but I don't know what else is out there).

}
}