Fix drop partition failure and wrong max task num (zilliztech#12)

zhuwenxing · Apr 12, 2023 · bd19d94 · bd19d94
1 parent 2cc4ff0
commit bd19d94
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/core/reader/milvus_reader.go b/core/reader/milvus_reader.go
@@ -521,14 +521,16 @@ func (reader *MilvusCollectionReader) readMsg(collectionName string, collectionI
 			if reader.filterMsgType(msgType) {
 				continue
 			}
-			// TODO fubang dropPartition no collection id
 			if reader.filterMsg(collectionName, collectionID, msg) {
 				continue
 			}
 			data := &model.CDCData{
 				Msg: msg,
 			}
 			if barrierManager.IsBarrierData(data) {
+				if dropPartitionMsg, ok := msg.(*msgstream.DropPartitionMsg); ok {
+					dropPartitionMsg.CollectionName = collectionName
+				}
 				barrierManager.AddData(vchannelName, data)
 				if _, ok := msg.(*msgstream.DropCollectionMsg); ok {
 					return

diff --git a/server/cdc_impl.go b/server/cdc_impl.go
@@ -183,7 +183,7 @@ func (e *MetaCDC) Create(req *request.CreateRequest) (resp *request.CreateRespon
 	if err != nil {
 		return nil, NewServerError(errors.WithMessage(err, "fail to get task list to check num"))
 	}
-	if getResp.Count > int64(e.config.MaxTaskNum) {
+	if getResp.Count >= int64(e.config.MaxTaskNum) {
 		return nil, NewServerError(errors.Newf("the task num has reach the limit, %d", e.config.MaxTaskNum))
 	}