Skip to content

Commit

Permalink
Use a consistent naming convention for elements
Browse files Browse the repository at this point in the history
* Element names we use "_" as word-delimiter, not "-"
* Element names use less camel-case
* Element names end with the type
* Element names always start with noVNC_
  • Loading branch information
samhed committed May 27, 2016
1 parent 682fd02 commit 3f2c25a
Show file tree
Hide file tree
Showing 5 changed files with 118 additions and 118 deletions.
40 changes: 20 additions & 20 deletions include/base.css
Original file line number Diff line number Diff line change
Expand Up @@ -56,10 +56,10 @@ html {
#noVNC_view_drag_button {
display: none;
}
#sendCtrlAltDelButton {
#noVNC_sendCtrlAltDel_button {
display: none;
}
#fullscreenButton {
#noVNC_fullscreen_button {
display: none;
}
#noVNC_xvp_buttons {
Expand All @@ -77,13 +77,13 @@ html {
position: relative;
}

.noVNC-buttons-left {
.noVNC_buttons_left {
float: left;
z-index: 1;
position: relative;
}

.noVNC-buttons-right {
.noVNC_buttons_right {
float:right;
right: 0px;
z-index: 2;
Expand Down Expand Up @@ -233,7 +233,7 @@ html {
right:85px;
}

#keyboardinput {
#noVNC_keyboardinput {
width:1px;
height:1px;
background-color:#fff;
Expand Down Expand Up @@ -278,7 +278,7 @@ html {
}

/* Control bar */
#noVNC-control-bar {
#noVNC_control_bar {
position:fixed;

display:block;
Expand Down Expand Up @@ -427,11 +427,11 @@ html {
font-size: 180px;
}

.noVNC-buttons-left {
.noVNC_buttons_left {
padding-left: 10px;
}

.noVNC-buttons-right {
.noVNC_buttons_right {
padding-right: 10px;
}

Expand All @@ -442,11 +442,11 @@ html {
margin-left: 0px;
}

#toggleExtraKeysButton { display: none; }
#toggleCtrlButton { display: inline; }
#toggleAltButton { display: inline; }
#sendTabButton { display: inline; }
#sendEscButton { display: inline; }
#noVNC_toggleExtraKeys_button { display: none; }
#noVNC_toggleCtrl_button { display: inline; }
#noVNC_toggleAlt_button { display: inline; }
#noVNC_sendTab_button { display: inline; }
#noVNC_sendEsc_button { display: inline; }

/* left-align the status text on lower resolutions */
@media screen and (max-width: 800px){
Expand All @@ -469,35 +469,35 @@ html {
.noVNC_status_button {
font-size: 10px;
}
.noVNC-buttons-left {
.noVNC_buttons_left {
padding-left: 0px;
}
.noVNC-buttons-right {
.noVNC_buttons_right {
padding-right: 0px;
}
/* collapse the extra keys on lower resolutions */
#toggleExtraKeysButton {
#noVNC_toggleExtraKeys_button {
display: inline;
}
#toggleCtrlButton {
#noVNC_toggleCtrl_button {
display: none;
position: absolute;
top: 30px;
left: 0px;
}
#toggleAltButton {
#noVNC_toggleAlt_button {
display: none;
position: absolute;
top: 65px;
left: 0px;
}
#sendTabButton {
#noVNC_sendTab_button {
display: none;
position: absolute;
top: 100px;
left: 0px;
}
#sendEscButton {
#noVNC_sendEsc_button {
display: none;
position: absolute;
top: 135px;
Expand Down
2 changes: 1 addition & 1 deletion include/black.css
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
* This file is licensed under the 2-Clause BSD license (see LICENSE.txt).
*/

#keyboardinput {
#noVNC_keyboardinput {
background-color:#000;
}

Expand Down
2 changes: 1 addition & 1 deletion include/blue.css
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@
color:#fff;
}

#keyboardinput {
#noVNC_keyboardinput {
background-color:#04073d;
}

Loading

0 comments on commit 3f2c25a

Please sign in to comment.