Skip to content

Commit

Permalink
fix: parse_url with fragment (apache#166)
Browse files Browse the repository at this point in the history
  • Loading branch information
jackylee-ch authored Sep 14, 2022
1 parent d389aab commit e9872bb
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions cpp/src/gandiva/parse_url_holder.h
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ namespace gandiva {
}
// check invalid charactor in fragment
if (fragment_start_idx != -1) {
for (int32_t idx = fragment_start_idx; idx < url_len; idx++) {
for (int32_t idx = fragment_start_idx + 1; idx < url_len; idx++) {
// consist with vanilla spark
if (url[idx] == ' ' || url[idx] == '{' || url[idx] == '}' || url[idx] == '#') {
return nullptr;
Expand Down Expand Up @@ -199,7 +199,7 @@ namespace gandiva {
}
// check invalid charactor in fragment
if (fragment_start_idx != -1) {
for (int32_t idx = fragment_start_idx; idx < url_len; idx++) {
for (int32_t idx = fragment_start_idx + 1; idx < url_len; idx++) {
// consist with vanilla spark
if (url[idx] == ' ' || url[idx] == '{' || url[idx] == '}' || url[idx] == '#') {
return nullptr;
Expand Down

0 comments on commit e9872bb

Please sign in to comment.