Merge pull request alibaba#153 from LQZYC/master

fix issue alibaba#68 support package name like ali88.ps.service
zhouchangju · Nov 1, 2017 · db90432 · db90432
2 parents 40bcf54 + 8a2cd82
commit db90432
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/p3c-pmd/src/main/java/com/alibaba/p3c/pmd/lang/java/rule/naming/PackageNamingRule.java b/p3c-pmd/src/main/java/com/alibaba/p3c/pmd/lang/java/rule/naming/PackageNamingRule.java
@@ -30,7 +30,7 @@
  */
 public class PackageNamingRule extends AbstractXpathRule {
     private static final String XPATH = "//PackageDeclaration/Name\n"
-        + "[not (matches(@Image, '^[a-z]+(\\.[a-z][a-z0-9]*)*$'))]";
+        + "[not (matches(@Image, '^[a-z0-9]+(\\.[a-z][a-z0-9]*)*$'))]";
 
     public PackageNamingRule() {
         setXPath(XPATH);

diff --git a/...md/src/test/resources/com/alibaba/p3c/pmd/lang/java/rule/naming/xml/PackageNamingRule.xml b/...md/src/test/resources/com/alibaba/p3c/pmd/lang/java/rule/naming/xml/PackageNamingRule.xml
@@ -31,5 +31,19 @@
     </test-code>
 
 
+    <code-fragment id="PackageNamingRule2">
+        <![CDATA[
+        package ali88.ps.service;
+        public class SomeClass {
+        }
+    ]]>
+    </code-fragment>
+    <test-code>
+        <description>Package Name should be lowercase</description>
+        <expected-problems>0</expected-problems>
+        <code-ref id="PackageNamingRule2" />
+    </test-code>
+
+
 
 </test-data>