Skip to content

Commit

Permalink
chore: fixing linting violations where @default documentation is miss…
Browse files Browse the repository at this point in the history
…ing (aws#2615)
  • Loading branch information
shivlaks authored and rix0rrr committed May 23, 2019
1 parent b9cbb6a commit f692c98
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 2 deletions.
6 changes: 5 additions & 1 deletion design/aws-ecs-autoscaling-queue-worker.md
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ export interface Ec2QueueWorkerServiceProps {
/**
* The minimum number of CPU units to reserve for the container.
*
* @default none
* @default - No minimum CPU units reserved.
*/
readonly cpu?: number;

Expand All @@ -123,6 +123,8 @@ export interface Ec2QueueWorkerServiceProps {
* is terminated.
*
* At least one of memoryLimitMiB and memoryReservationMiB is required for non-Fargate services.
*
* @default - No memory limit.
*/
readonly memoryLimitMiB?: number;

Expand All @@ -135,6 +137,8 @@ export interface Ec2QueueWorkerServiceProps {
* the available memory on the container instance—whichever comes first.
*
* At least one of memoryLimitMiB and memoryReservationMiB is required for non-Fargate services.
*
* @default - No memory reserved.
*/
readonly memoryReservationMiB?: number;
}
Expand Down
6 changes: 5 additions & 1 deletion packages/@aws-cdk/aws-ecs/lib/ecs-queue-worker-service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ export interface Ec2QueueWorkerServiceProps extends QueueWorkerServiceBaseProps
/**
* The minimum number of CPU units to reserve for the container.
*
* @default none
* @default - No minimum CPU units reserved.
*/
readonly cpu?: number;

Expand All @@ -21,6 +21,8 @@ export interface Ec2QueueWorkerServiceProps extends QueueWorkerServiceBaseProps
* is terminated.
*
* At least one of memoryLimitMiB and memoryReservationMiB is required for non-Fargate services.
*
* @default - No memory limit.
*/
readonly memoryLimitMiB?: number;

Expand All @@ -33,6 +35,8 @@ export interface Ec2QueueWorkerServiceProps extends QueueWorkerServiceBaseProps
* the available memory on the container instance—whichever comes first.
*
* At least one of memoryLimitMiB and memoryReservationMiB is required for non-Fargate services.
*
* @default - No memory reserved.
*/
readonly memoryReservationMiB?: number;
}
Expand Down

0 comments on commit f692c98

Please sign in to comment.