Skip to content

Commit

Permalink
chore(logs): remove hardcoded account id and region from snapshot (aw…
Browse files Browse the repository at this point in the history
…s#27621)

In aws#26498, I injected specific account id and region in integration test snapshot by mistake. This PR replaces them with variables by taking snapshot correctly.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
  • Loading branch information
tam0ri authored Oct 20, 2023
1 parent 0e81c19 commit a1ad28b
Show file tree
Hide file tree
Showing 7 changed files with 35 additions and 39 deletions.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,7 @@ class SubscriptionFilterIntegStack extends Stack {
}

const app = new App();
const testCase = new SubscriptionFilterIntegStack(app, 'aws-cdk-subscriptionfilter-integ', {
env: {
account: process.env.CDK_INTEG_ACCOUNT || process.env.CDK_DEFAULT_ACCOUNT,
region: process.env.CDK_INTEG_REGION || process.env.CDK_DEFAULT_REGION,
},
});
const testCase = new SubscriptionFilterIntegStack(app, 'aws-cdk-subscriptionfilter-integ');

new IntegTest(app, 'integ-test', {
testCases: [testCase],
Expand Down

0 comments on commit a1ad28b

Please sign in to comment.