-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improves optional imports #366
Improves optional imports #366
Conversation
|
Codecov Report
@@ Coverage Diff @@
## main #366 +/- ##
=======================================
Coverage 98.58% 98.58%
=======================================
Files 11 11
Lines 778 778
=======================================
Hits 767 767
Misses 11 11
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mattpopovich , the overall looks great to me! I only make one comment about where to place the decorator, let me know if you have more concerns.
for more information, see https://pre-commit.ci
cc1ff8b
to
55a3a42
Compare
for more information, see https://pre-commit.ci
Hi @mattpopovich , since #369 introduces some conflicts, I rebase this PR manually, and please use the following command to synchronize with the current branch: git pull --rebase origin improve-optional-imports |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks GREAT to me, thanks @mattpopovich for your great contributions here! And I'm merging this PR!
Fixes #353