Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing version param in export_tensorrt #335

Merged
merged 1 commit into from
Feb 23, 2022

Conversation

Luwill6
Copy link
Contributor

@Luwill6 Luwill6 commented Feb 23, 2022

No description provided.

@CLAassistant
Copy link

CLAassistant commented Feb 23, 2022

CLA assistant check
All committers have signed the CLA.

@zhiqwang zhiqwang added the bug / fix Something isn't working label Feb 23, 2022
@zhiqwang zhiqwang changed the title add version param Add missing version param in export_tensorrt Feb 23, 2022
@codecov
Copy link

codecov bot commented Feb 23, 2022

Codecov Report

Merging #335 (ef58e0c) into main (3af7e4d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #335   +/-   ##
=======================================
  Coverage   95.38%   95.38%           
=======================================
  Files          11       11           
  Lines         759      759           
=======================================
  Hits          724      724           
  Misses         35       35           
Flag Coverage Δ
unittests 95.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3af7e4d...ef58e0c. Read the comment docs.

Copy link
Owner

@zhiqwang zhiqwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Luwill6 , LGTM!

@zhiqwang zhiqwang merged commit 63341ec into zhiqwang:main Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug / fix Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants