Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pre-processing in TensorRT C++ example #321

Merged
merged 1 commit into from
Feb 17, 2022
Merged

Fix pre-processing in TensorRT C++ example #321

merged 1 commit into from
Feb 17, 2022

Conversation

ShiquanYu
Copy link
Contributor

@ShiquanYu ShiquanYu commented Feb 17, 2022 •
edited by zhiqwang
Loading

  • Add BGR2RGB in pre-processing
  • Fix offset in letterboxing

@zhiqwang zhiqwang added the bug / fix Something isn't working label Feb 17, 2022
@codecov
Copy link

codecov bot commented Feb 17, 2022 •
edited
Loading

Codecov Report

Merging #321 (5d977dd) into main (724f60e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #321   +/-   ##
=======================================
  Coverage   95.38%   95.38%           
=======================================
  Files          11       11           
  Lines         759      759           
=======================================
  Hits          724      724           
  Misses         35       35
Flag Coverage Δ
unittests 95.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 724f60e...5d977dd. Read the comment docs.

@zhiqwang zhiqwang changed the title Add BGR2RGB while process image Fix pre-processing in TensorRT C++ example Feb 17, 2022
zhiqwang
zhiqwang approved these changes Feb 17, 2022
View reviewed changes
Copy link
Owner

@zhiqwang zhiqwang left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks @ShiquanYu for the debugging and @Luwill6 for reporting this issue.

@zhiqwang zhiqwang merged commit 345a77e into zhiqwang:main Feb 17, 2022
@zhiqwang zhiqwang added the deployment Inference acceleration for production label Feb 17, 2022
@zhiqwang zhiqwang mentioned this pull request Feb 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhiqwang zhiqwang zhiqwang approved these changes

Assignees
No one assigned
Labels
bug / fix Something isn't working deployment Inference acceleration for production
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShiquanYu @zhiqwang