Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing build_targets in SetCriterion #143

Merged
merged 16 commits into from
Sep 9, 2021
Merged

Conversation

zhiqwang
Copy link
Owner

Fixing #60

@zhiqwang zhiqwang mentioned this pull request Jul 19, 2021
9 tasks
@zhiqwang zhiqwang added the enhancement New feature or request label Jul 20, 2021
@zhiqwang zhiqwang force-pushed the fixing-building-targets branch 4 times, most recently from 92134cb to 05a8ae9 Compare September 7, 2021 03:08
@codecov
Copy link

codecov bot commented Sep 9, 2021

Codecov Report

Merging #143 (609399f) into master (cc2bd50) will increase coverage by 0.78%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #143      +/-   ##
==========================================
+ Coverage   83.44%   84.22%   +0.78%     
==========================================
  Files          12       12              
  Lines         761      748      -13     
==========================================
- Hits          635      630       -5     
+ Misses        126      118       -8     
Flag Coverage Δ
unittests 84.22% <100.00%> (+0.78%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
test/test_engine.py 100.00% <ø> (+5.67%) ⬆️
test/test_models_utils.py 100.00% <ø> (ø)
test/test_models.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc2bd50...609399f. Read the comment docs.

@zhiqwang zhiqwang merged commit b6d8e00 into master Sep 9, 2021
@zhiqwang zhiqwang deleted the fixing-building-targets branch September 9, 2021 17:57
@zhiqwang zhiqwang added the bug / fix Something isn't working label Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug / fix Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant