Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace cxxopts with cmdline #137

Merged
merged 2 commits into from
Jul 14, 2021
Merged

Replace cxxopts with cmdline #137

merged 2 commits into from
Jul 14, 2021

Conversation

zhiqwang
Copy link
Owner

Resolve #135

@codecov
Copy link

codecov bot commented Jul 14, 2021

Codecov Report

Merging #137 (f4553fb) into master (ec5464d) will not change coverage.
The diff coverage is n/a.

❗ Current head f4553fb differs from pull request most recent head ab79400. Consider uploading reports for the commit ab79400 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #137   +/-   ##
=======================================
  Coverage   83.56%   83.56%           
=======================================
  Files           8        8           
  Lines         779      779           
=======================================
  Hits          651      651           
  Misses        128      128           
Flag Coverage Δ
unittests 83.56% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec5464d...ab79400. Read the comment docs.

@zhiqwang zhiqwang force-pushed the replace-cxxopts-with-cmdline branch 2 times, most recently from 17b301f to ab79400 Compare July 14, 2021 04:01
@zhiqwang zhiqwang force-pushed the replace-cxxopts-with-cmdline branch from ab79400 to 4864b8f Compare July 14, 2021 04:02
@zhiqwang zhiqwang merged commit 5395621 into master Jul 14, 2021
@zhiqwang zhiqwang deleted the replace-cxxopts-with-cmdline branch July 14, 2021 04:02
@zhiqwang zhiqwang added the bug / fix Something isn't working label Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug / fix Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cxxopts will cause problems in several scenarios
1 participant