simplify function_ref code by deducing noexcept-ness #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e branching for void return type
hanickadot
changed the title
|
also fixed clang compilation error due template template mismatch |
hanickadot
changed the title
|
Seems unsupported by MSVC |
|
PS: which version of Clang were you testing? |
|
I tried it with clang 17.0.6 and 16.0.6. 15 and lower has some errors (looked just now) will fix them tomorrow. MSVC makes me sad. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
function_ref implementation can be simplified a bit by deducing noexcept-ness