Skip to content

Commit

Permalink
[KYUUBI apache#5867][FOLLOWUP] Fix generated configuration docs and typo
Browse files Browse the repository at this point in the history 
# 🔍 Description
## Issue References 🔗

This pull request is a follow-up of apache#5867, to fix generated configuration docs and typo to recover CI.

## Describe Your Solution 🔧

Regenerated docs by performing `dev/gen/gen_all_config_docs.sh`
Address comment apache#5868 (comment)

## Types of changes 🔖

- [x] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)

## Test Plan 🧪

Pass GA.

---

# Checklist 📝

- [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html)

**Be nice. Be informative.**

Closes apache#5932 from pan3793/fix-docs.

Closes apache#5867

93b8f97 [Cheng Pan] docs
0ad0d29 [Cheng Pan] typo

Authored-by: Cheng Pan <chengpan@apache.org>
Signed-off-by: Cheng Pan <chengpan@apache.org>
  • Loading branch information
@pan3793 @zhaohehuhu
pan3793 authored and zhaohehuhu committed Mar 21, 2024
1 parent 9bfbd4b commit e440562
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 8 deletions.
10 changes: 5 additions & 5 deletions docs/configuration/settings.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -205,16 +205,16 @@ You can configure the Kyuubi properties in `$KYUUBI_HOME/conf/kyuubi-defaults.co
| kyuubi.engine.user.isolated.spark.session | true | When set to false, if the engine is running in a group or server share level, all the JDBC/ODBC connections will be isolated against the user. Including the temporary views, function registries, SQL configuration, and the current database. Note that, it does not affect if the share level is connection or user. | boolean | 1.6.0 |
| kyuubi.engine.user.isolated.spark.session.idle.interval | PT1M | The interval to check if the user-isolated Spark session is timeout. | duration | 1.6.0 |
| kyuubi.engine.user.isolated.spark.session.idle.timeout | PT6H | If kyuubi.engine.user.isolated.spark.session is false, we will release the Spark session if its corresponding user is inactive after this configured timeout. | duration | 1.6.0 |
| kyuubi.engine.yarn.app.name | (none) | The YARN app name when the engine deploy mode is YARN. | string | 1.9.0 |
| kyuubi.engine.yarn.app.name | &lt;undefined&gt; | The YARN app name when the engine deploy mode is YARN. | string | 1.9.0 |
| kyuubi.engine.yarn.cores | 1 | kyuubi engine container core number when the engine deploy mode is YARN. | int | 1.9.0 |
| kyuubi.engine.yarn.java.options | (none) | The extra Java options for the AM when the engine deploy mode is YARN. | string | 1.9.0 |
| kyuubi.engine.yarn.java.options | &lt;undefined&gt; | The extra Java options for the AM when the engine deploy mode is YARN. | string | 1.9.0 |
| kyuubi.engine.yarn.memory | 1024 | kyuubi engine container memory in mb when the engine deploy mode is YARN. | int | 1.9.0 |
| kyuubi.engine.yarn.priority | (none) | kyuubi engine yarn priority when the engine deploy mode is YARN. | int | 1.9.0 |
| kyuubi.engine.yarn.priority | &lt;undefined&gt; | kyuubi engine yarn priority when the engine deploy mode is YARN. | int | 1.9.0 |
| kyuubi.engine.yarn.queue | default | kyuubi engine yarn queue when the engine deploy mode is YARN. | string | 1.9.0 |
| kyuubi.engine.yarn.report.interval | PT1S | Interval between reports of the current engine on yarn app status. | duration | 1.9.0 |
| kyuubi.engine.yarn.stagingDir | (none) | Staging directory used while submitting kyuubi engine to YARN, It should be a absolute path in HDFS. | string | 1.9.0 |
| kyuubi.engine.yarn.stagingDir | &lt;undefined&gt; | Staging directory used while submitting kyuubi engine to YARN, It should be a absolute path in HDFS. | string | 1.9.0 |
| kyuubi.engine.yarn.submit.timeout | PT30S | The engine submit timeout for YARN application. | duration | 1.7.2 |
| kyuubi.engine.yarn.tags | (none) | kyuubi engine yarn tags when the engine deploy mode is YARN. | seq | 1.9.0 |
| kyuubi.engine.yarn.tags | &lt;undefined&gt; | kyuubi engine yarn tags when the engine deploy mode is YARN. | seq | 1.9.0 |

### Event

Expand Down
2 changes: 1 addition & 1 deletion ...s/kyuubi-hive-sql-engine/src/main/scala/org/apache/kyuubi/engine/hive/HiveSQLEngine.scala
View file
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ class HiveSQLEngine extends Serverable("HiveSQLEngine") {
// Start engine self-terminating checker after all services are ready and it can be reached by
// all servers in engine spaces.
backendService.sessionManager.startTerminatingChecker(() => {
selfExist = true
selfExited = true
stop()
})
}
Expand Down
Loading

0 comments on commit e440562

Please sign in to comment.