update dynamicImport default, add test case

zhangming · Feb 3, 2022 · b254f35 · b254f35
1 parent 3f10a17
commit b254f35
Show file tree

Hide file tree

Showing 5 changed files with 31 additions and 1 deletion.
diff --git a/lib/config/defaults.js b/lib/config/defaults.js
@@ -921,7 +921,11 @@ const applyOutputDefaults = (
 	);
 	F(output.environment, "forOf", () => tp && optimistic(tp.forOf));
 	F(output.environment, "bigIntLiteral", () => tp && tp.bigIntLiteral);
-	F(output.environment, "dynamicImport", () => tp && tp.dynamicImport);
+	F(
+		output.environment,
+		"dynamicImport",
+		() => tp && conditionallyOptimistic(tp.dynamicImport, output.module)
+	);
 	F(
 		output.environment,
 		"module",

diff --git a/test/Defaults.unittest.js b/test/Defaults.unittest.js
@@ -882,6 +882,9 @@ describe("Defaults", () => {
 		-     "chunkFilename": "[name].js",
 		+     "chunkFilename": "[name].mjs",
 		@@ ... @@
+		-       "dynamicImport": undefined,
+		+       "dynamicImport": true,
+		@@ ... @@
 		-       "module": undefined,
 		+       "module": true,
 		@@ ... @@

diff --git a/test/configCases/output-module/check-defaults/errors.js b/test/configCases/output-module/check-defaults/errors.js
@@ -0,0 +1,3 @@
+module.exports = [
+	[/For the selected environment is no default ESM chunk format available/]
+];
diff --git a/test/configCases/output-module/check-defaults/index.js b/test/configCases/output-module/check-defaults/index.js
@@ -0,0 +1,3 @@
+it("should compile and run", () => {
+	expect(import.meta.url).toBe(import.meta.url);
+});
diff --git a/test/configCases/output-module/check-defaults/webpack.config.js b/test/configCases/output-module/check-defaults/webpack.config.js
@@ -0,0 +1,17 @@
+/** @type {import("../../../../").Configuration[]} */
+module.exports = [
+	{
+		experiments: {
+			outputModule: true
+		},
+		devtool: false,
+		target: "web"
+	},
+	{
+		experiments: {
+			outputModule: true
+		},
+		devtool: false,
+		target: "node10"
+	}
+];