fix cache invalidation in HttpUriPlugin

- should not store partial result when following redirect
zhangming · Feb 10, 2022 · a6099c4 · a6099c4
1 parent 0d38e57
commit a6099c4
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/lib/schemes/HttpUriPlugin.js b/lib/schemes/HttpUriPlugin.js
@@ -543,6 +543,15 @@ class HttpUriPlugin {
 										logger.debug(
 											`GET ${url} [${res.statusCode}] -> ${partialResult.location}`
 										);
+										// we should follow redirect and not store partial result
+										return callback(null, {
+											...partialResult,
+											storeLock,
+											storeCache,
+											fresh: true,
+											etag: undefined,
+											validUntil: undefined
+										});
 									} else {
 										logger.debug(
 											`GET ${url} [${res.statusCode}] ${Math.ceil(

diff --git a/test/ConfigCacheTestCases.longtest.js b/test/ConfigCacheTestCases.longtest.js
@@ -28,11 +28,6 @@ describeCases({
 				// Pack got invalid because of write to: TerserWebpackPlugin|bundle0.js
 				category: "assets",
 				test: "delete-asset"
-			},
-			{
-				// Pack got invalid because of write to: webpack.HttpUriPlugin|https://raw.githubusercontent.com//webpack//webpack//main/CODE_OF_CONDUCT.md
-				category: "asset-modules",
-				test: "http-url"
 			}
 		],
 		filter: [logErrors.PERSISTENCE_CACHE_INVALIDATE_ERROR]