Skip to content

Fix bug caused by unrelated active greenlets. #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix bug caused by unrelated active greenlets. #3

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fb36257
Fix bug preventing non-related gevent workers being active in burst
mtsgrd Jan 29, 2015
4b31aaf
Merge pull request #1 from mtsgrd/master
mtsgrd Jan 29, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion rq_gevent_worker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ def __init__(self, *args, **kwargs):
if 'pool_size' in kwargs:
pool_size = kwargs.pop('pool_size')
self.gevent_pool = gevent.pool.Pool(pool_size)
self.children = []
super(GeventWorker, self).__init__(*args, **kwargs)

def register_birth(self):
Expand Down Expand Up @@ -102,7 +103,7 @@ def work(self, burst=False):
if result is None and burst:
try:
# Make sure dependented jobs are enqueued.
get_hub().switch()
gevent.wait(self.children)
except LoopExit:
pass
result = self.dequeue_job_and_maintain_ttl(timeout)
Expand All @@ -122,13 +123,15 @@ def work(self, burst=False):

def execute_job(self, job, queue):
def job_done(child):
self.children.remove(child)
self.did_perform_work = True
self.heartbeat()
if job.get_status() == Status.FINISHED:
queue.enqueue_dependents(job)

child_greenlet = self.gevent_pool.spawn(self.perform_job, job)
child_greenlet.link(job_done)
self.children.append(child_greenlet)

def dequeue_job_and_maintain_ttl(self, timeout):
if self._stopped:
Expand Down