Skip to content

Commit

Permalink
Update AppCommand spec, emphasise that path has to be under ProgramFiles
Browse files Browse the repository at this point in the history
Bug: 1318293
Change-Id: I7b13ce586b1035481fd1917b10b09bf42f2d1fee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4234231
Reviewed-by: Xiaoling Bao <xiaolingbao@chromium.org>
Auto-Submit: S Ganesh <ganesh@chromium.org>
Commit-Queue: Xiaoling Bao <xiaolingbao@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1103141}
  • Loading branch information
GitHubGanesh authored and Chromium LUCI CQ committed Feb 9, 2023
1 parent 580d233 commit 5e621d4
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions docs/updater/functional_spec.md
Original file line number Diff line number Diff line change
Expand Up @@ -864,8 +864,8 @@ command lines can be registered per `app_id`.

This feature is only for system applications.

The program path is always an absolute path. Additionally, the program path is
also a child of %ProgramFiles% or %ProgramFiles(x86)%. For instance:
The program path is always an absolute path. Additionally, the program path has
to be a child of %ProgramFiles% or %ProgramFiles(x86)%. For instance:
* `c:\path-to-exe\exe.exe` is an invalid path.
* `"c:\Program Files\subdir\exe.exe"` is a valid path.
* `"c:\Program Files (x86)\subdir\exe.exe"` is also a valid path.
Expand All @@ -887,7 +887,7 @@ parameters substituted at runtime. Multiple app commands can be registered per
`app_id`.

The program path is always an absolute path. Additionally, for system
applications, the program path is also a child of %ProgramFiles% or
applications, the program path has to be a child of %ProgramFiles% or
%ProgramFiles(x86)%. For instance:
* `c:\path-to-exe\exe.exe` is an invalid path.
* `"c:\Program Files\subdir\exe.exe"` is a valid path.
Expand Down Expand Up @@ -963,8 +963,8 @@ using the `status` method of `IAppCommandWeb`. When the status is
exit code.

#### Command-Line Format
* for system applications, the executable path is in a secure location such
as `%ProgramFiles%` for security, since it runs elevated.
* for system applications, the executable path has to be a child of
`%ProgramFiles%` or `%ProgramFiles(x86)%` for security, since it runs elevated.
* placeholders are not permitted in the executable path.
* placeholders take the form of a percent character `%` followed by a digit.
Literal `%` characters are escaped by doubling them.
Expand Down

0 comments on commit 5e621d4

Please sign in to comment.