Skip to content

Commit

Permalink
[@container] Improve assert_implements for container-types
Browse files Browse the repository at this point in the history
Use separate assertions for size, scroll-state, and style queries.

Since style queries are not detectable through CSS.supports, use
serialization of <general-enclosed> for now.

Change-Id: Ia2ebd2b19ae25af3bd7a2ad6b77133e496f0c46e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5979992
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1376840}
  • Loading branch information
lilles authored and pull[bot] committed Nov 1, 2024
1 parent fd9497d commit 1412915
Show file tree
Hide file tree
Showing 146 changed files with 186 additions and 149 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
</div>
</div>
<script>
setup(() => assert_implements_container_queries());
setup(() => assert_implements_size_container_queries());

test(() => {
assert_equals(getComputedStyle(target).backgroundColor, 'rgb(0, 0, 255)');
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
</div>
</div>
<script>
setup(() => assert_implements_container_queries());
setup(() => assert_implements_size_container_queries());

test(() => {
assert_equals(getComputedStyle(target).backgroundColor, 'rgb(0, 0, 255)');
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
</div>
</div>
<script>
setup(() => assert_implements_container_queries());
setup(() => assert_implements_size_container_queries());

test(() => {
assert_equals(getComputedStyle(target).backgroundColor, 'rgb(0, 128, 0)');
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
</div>
</div>
<script>
setup(() => assert_implements_container_queries());
setup(() => assert_implements_size_container_queries());

test(() => {
assert_equals(getComputedStyle(target).backgroundColor, 'rgb(100, 100, 100)');
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
<div id="inline-size" class="container"><span></span></div>
<div id="size" class="container"><span></span></div>
<script>
setup(() => assert_implements_container_queries());
setup(() => assert_implements_size_container_queries());

const red = "rgb(255, 0, 0)";
const green = "rgb(0, 128, 0)";
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
<main id="cq-main"></main>
</div>
<script>
setup(() => assert_implements_container_queries());
setup(() => assert_implements_size_container_queries());

test_cq_condition_known('(width)');
test_cq_condition_known('(min-width: 0px)');
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
@container (calc(1em + 1px) >= width >= max(10em, 10px)) { }
</style>
<script>
setup(() => assert_implements_container_queries());
setup(() => assert_implements_size_container_queries());

let rules = testSheet.sheet.cssRules;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
<main id="cq-main"></main>
</div>
<script>
setup(() => assert_implements_container_queries());
setup(() => assert_implements_style_container_queries());

test_cq_condition_known('style(--my-prop: foo)');
test_cq_condition_known('style(--my-prop: foo - bar ())');
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
</style>
<script>
setup(() => {
assert_implements_container_queries();
assert_implements_style_container_queries();
assert_equals(testSheet.sheet.cssRules.length, 8);
});

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
</div>
<script>
setup(() => {
assert_implements_container_queries();
assert_implements_size_container_queries();
assert_implements_optional(precondition.clientWidth < 100,
"Tests do not work with overlay scrollbars");
});
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
<dialog>test</dialog>
</main>
<script>
setup(() => assert_implements_container_queries());
setup(() => assert_implements_size_container_queries());

let dialog = document.querySelector('dialog');

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
<div id=target></div>
</div>
<script>
setup(() => assert_implements_container_queries());
setup(() => assert_implements_size_container_queries());

test(() => {
assert_equals(getComputedStyle(target).color, 'rgb(0, 128, 0)');
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
<div id="target" tabIndex="1"></div>
</canvas>
<script>
setup(() => assert_implements_container_queries());
setup(() => assert_implements_size_container_queries());

test(() => {
target.focus();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
<div id="target" tabIndex="1"></div>
</canvas>
<script>
setup(() => assert_implements_container_queries());
setup(() => assert_implements_size_container_queries());

test(() => {
target.focus();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
<div id="spanner"></div>
</div>
<script>
setup(() => assert_implements_container_queries());
setup(() => assert_implements_size_container_queries());

test(() => {
assert_equals(getComputedStyle(spanner).width, "600px");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
</div>
</div>
<script>
setup(() => assert_implements_container_queries());
setup(() => assert_implements_size_container_queries());

test(function() {
let s = getComputedStyle(document.querySelector('.grandchild'));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
<script src="support/cq-testcommon.js"></script>
<div id="target"></div>
<script>
setup(() => assert_implements_container_queries());
setup(() => assert_implements_size_container_queries());

test_computed_value('container', 'initial', 'none');
test_computed_value('container', 'inherit', 'none');
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -343,7 +343,7 @@

<script>
setup(() => {
assert_implements_container_queries();
assert_implements_size_container_queries();
});

const green = "rgb(0, 128, 0)";
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
<div id="target"></div>
</div>
<script>
setup(() => assert_implements_container_queries());
setup(() => assert_implements_size_container_queries());

assert_not_inherited('container-name', 'none', 'foo');
assert_not_inherited('container-type', 'normal', 'inline-size');
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
</div>

<script>
setup(() => assert_implements_container_queries());
setup(() => assert_implements_size_container_queries());
</script>

<style>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
</table>
</div>
<script>
setup(() => assert_implements_container_queries());
setup(() => assert_implements_size_container_queries());

const green = "rgb(0, 128, 0)";

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
<div id=container>
</div>
<script>
setup(() => assert_implements_container_queries());
setup(() => assert_implements_size_container_queries());

test(() => {
assert_equals(getComputedStyle(container).getPropertyValue('--ref'), 'PASS');
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
<script src="support/cq-testcommon.js"></script>
<div id="target"></div>
<script>
setup(() => assert_implements_container_queries());
setup(() => assert_implements_size_container_queries());

test_computed_value('container-name', 'initial', 'none');
test_computed_value('container-name', 'unset', 'none');
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
</div>
</div>
<script>
setup(() => assert_implements_container_queries());
setup(() => assert_implements_size_container_queries());

test(function(t) {
t.add_cleanup(() => { outer.style = ''; });
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
<script src="support/cq-testcommon.js"></script>
<div id="target"></div>
<script>
setup(() => assert_implements_container_queries());
setup(() => assert_implements_size_container_queries());

test_valid_value('container-name', 'initial');
test_valid_value('container-name', 'inherit');
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@

<script>
setup(() => {
assert_implements_container_queries();
assert_implements_size_container_queries();
});

const green = "rgb(0, 128, 0)";
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
</div>
</div>
<script>
setup(() => assert_implements_container_queries());
setup(() => assert_implements_size_container_queries());
</script>

<!--
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
<script src="support/cq-testcommon.js"></script>
<div id="target"></div>
<script>
setup(() => assert_implements_container_queries());
setup(() => assert_implements_size_container_queries());

test_valid_value('container', 'initial');
test_valid_value('container', 'inherit');
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,10 @@
<div id="t4">Green</div>
</div>
<script>
setup(() => assert_implements_container_queries());
setup(() => {
assert_implements_size_container_queries();
assert_implements_style_container_queries();
});

const green = "rgb(0, 128, 0)";
test(() => { assert_equals(getComputedStyle(t1).color, green); }, "width query with (foo: bar)");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@
</main>

<script>
setup(() => assert_implements_container_queries());
setup(() => assert_implements_size_container_queries());

function test_query(prelude, selector, expected) {
test(t => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
</div>
</div>
<script>
setup(() => assert_implements_container_queries());
setup(() => assert_implements_size_container_queries());

function waitForLoad(w) {
return new Promise(resolve => w.addEventListener('load', resolve));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
</div>
</main>
<script>
setup(() => assert_implements_container_queries());
setup(() => assert_implements_size_container_queries());

test(function() {
assert_equals(getComputedStyle(child).color, 'rgb(255, 0, 0)');
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
</div>
</div>
<script>
setup(() => assert_implements_container_queries());
setup(() => assert_implements_size_container_queries());

test(function() {
assert_equals(getComputedStyle(outer_child).getPropertyValue('--outer'), 'true');
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
</div>
<script>
setup(() => {
assert_implements_container_queries();
assert_implements_size_container_queries();
});

const green = "rgb(0, 128, 0)";
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
<script src="support/cq-testcommon.js"></script>
<div id="target"></div>
<script>
setup(() => assert_implements_container_queries());
setup(() => assert_implements_size_container_queries());

test_computed_value('container-type', 'initial', 'normal');
test_computed_value('container-type', 'unset', 'normal');
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<script src="/resources/testharnessreport.js"></script>
<script src="support/cq-testcommon.js"></script>
<script>
setup(() => assert_implements_container_queries());
setup(() => assert_implements_size_container_queries());
</script>

<style>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
</div>
</div>
<script>
setup(() => assert_implements_container_queries());
setup(() => assert_implements_size_container_queries());

test(function(t) {
t.add_cleanup(() => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
content
</div>
<script>
setup(() => assert_implements_container_queries());
setup(() => assert_implements_size_container_queries());

test(function(t) {
t.add_cleanup(() => { div.style = ''; });
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
<script src="support/cq-testcommon.js"></script>
<div id="target"></div>
<script>
setup(() => assert_implements_container_queries());
setup(() => assert_implements_size_container_queries());

test_valid_value('container-type', 'initial');
test_valid_value('container-type', 'inherit');
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
<div id=element_cqmax></div>
</div>
<script>
setup(() => assert_implements_container_queries());
setup(() => assert_implements_size_container_queries());

const units = ['cqw', 'cqh', 'cqi', 'cqb', 'cqmin', 'cqmax'];

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
</div>
</div>
<script>
setup(() => assert_implements_container_queries());
setup(() => assert_implements_size_container_queries());

function assert_unit_equals(element, actual, expected) {
try {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<script src="/resources/testharnessreport.js"></script>
<script src="support/cq-testcommon.js"></script>
<script>
setup(() => assert_implements_container_queries());
setup(() => assert_implements_size_container_queries());

const units = ['cqw', 'cqh', 'cqi', 'cqb', 'cqmin', 'cqmax'];

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
<div id=child2></div>
</div>
<script>
setup(() => assert_implements_container_queries());
setup(() => assert_implements_size_container_queries());

function assert_unit_equals(element, actual, expected) {
try {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
</div>

<script>
setup(() => assert_implements_container_queries());
setup(() => assert_implements_size_container_queries());

test(() => {
assert_equals(getComputedStyle(child).getPropertyValue('--cqw'), '');
Expand Down
Loading

0 comments on commit 1412915

Please sign in to comment.