Fix compaction panic (milvus-io#17840)

See also: milvus-io#17823 Signed-off-by: yangxuan <xuan.yang@zilliz.com>
zhagnlu · Jun 29, 2022 · ff3c4ab · ff3c4ab
1 parent 24b3ad2
commit ff3c4ab
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/internal/datacoord/meta.go b/internal/datacoord/meta.go
@@ -1071,7 +1071,8 @@ func buildSegment(collectionID UniqueID, partitionID UniqueID, segmentID UniqueI
 }
 
 func isSegmentHealthy(segment *SegmentInfo) bool {
-	return segment.GetState() != commonpb.SegmentState_SegmentStateNone &&
+	return segment != nil &&
+		segment.GetState() != commonpb.SegmentState_SegmentStateNone &&
 		segment.GetState() != commonpb.SegmentState_NotExist &&
 		segment.GetState() != commonpb.SegmentState_Dropped
 }

diff --git a/internal/datacoord/meta_test.go b/internal/datacoord/meta_test.go
@@ -755,3 +755,9 @@ func TestMeta_GetAllSegments(t *testing.T) {
 	assert.Nil(t, seg2)
 	assert.NotNil(t, seg2All)
 }
+
+func TestMeta_isSegmentHealthy_issue17823_panic(t *testing.T) {
+	var seg *SegmentInfo
+
+	assert.False(t, isSegmentHealthy(seg))
+}