Fix RHNSWPQ pqm divide by zero (milvus-io#18700)

See also: milvus-io#18671 Signed-off-by: yangxuan <xuan.yang@zilliz.com> Signed-off-by: yangxuan <xuan.yang@zilliz.com>
zhagnlu · Aug 18, 2022 · a782ded · a782ded
1 parent cf1c590
commit a782ded
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/internal/util/indexparamcheck/conf_adapter.go b/internal/util/indexparamcheck/conf_adapter.go
@@ -419,7 +419,7 @@ func (adapter *RHNSWPQConfAdapter) CheckTrain(params map[string]string) bool {
 		return false
 	}
 	pqm, err := strconv.Atoi(pqmStr)
-	if err != nil {
+	if err != nil || pqm == 0 {
 		return false
 	}
 

diff --git a/internal/util/indexparamcheck/conf_adapter_test.go b/internal/util/indexparamcheck/conf_adapter_test.go
@@ -461,6 +461,9 @@ func TestRHNSWPQConfAdapter_CheckTrain(t *testing.T) {
 	invalidParamsPQM := copyParams(validParams)
 	invalidParamsPQM[PQM] = "NAN"
 
+	invalidParamsPQMZero := copyParams(validParams)
+	invalidParamsPQMZero[PQM] = "0"
+
 	cases := []struct {
 		params map[string]string
 		want   bool
@@ -473,6 +476,7 @@ func TestRHNSWPQConfAdapter_CheckTrain(t *testing.T) {
 		{invalidMParamsMax, false},
 		{invalidParamsWithoutPQM, false},
 		{invalidParamsPQM, false},
+		{invalidParamsPQMZero, false},
 	}
 
 	adapter := newRHNSWPQConfAdapter()