Fix Autoindex panic (milvus-io#24602)

Signed-off-by: chasingegg <chao.gao@zilliz.com>
zhagnlu · Jun 1, 2023 · 1a60fe4 · 1a60fe4
1 parent 5710752
commit 1a60fe4
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 0 deletions.
diff --git a/internal/util/paramtable/autoindex_param.go b/internal/util/paramtable/autoindex_param.go
@@ -76,6 +76,7 @@ func (p *autoIndexConfig) initParams() {
 	}
 	p.indexParamsStr = p.Base.LoadWithDefault("autoIndex.params.build", "")
 	p.parseBuildParams(p.indexParamsStr)
+	p.panicIfNotInvalid()
 
 	p.SearchParamsYamlStr = p.Base.LoadWithDefault("autoIndex.params.search", "")
 

diff --git a/internal/util/paramtable/autoindex_param_test.go b/internal/util/paramtable/autoindex_param_test.go
@@ -126,6 +126,21 @@ func Test_autoIndexConfig_panicIfNotInvalid(t *testing.T) {
 		assert.Equal(t, indexparamcheck.FloatVectorDefaultMetricType, metricType)
 	})
 
+	t.Run("normal case, hnsw2", func(t *testing.T) {
+		p := &autoIndexConfig{
+			Enable: true,
+			IndexParams: map[string]string{
+				common.IndexTypeKey: indexparamcheck.IndexHNSW,
+				"M":                 "30",
+				"efConstruction":    "360",
+			},
+		}
+		assert.NotPanics(t, p.panicIfNotInvalid)
+		metricType, exist := p.IndexParams[common.MetricTypeKey]
+		assert.True(t, exist)
+		assert.Equal(t, indexparamcheck.FloatVectorDefaultMetricType, metricType)
+	})
+
 	t.Run("normal case, ivf flat", func(t *testing.T) {
 		p := &autoIndexConfig{
 			Enable: false,