Skip to content

Merge changes fom master and add workaround for DASH shell problems #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 12, 2019
Merged

Conversation

stuehmer
Copy link
Contributor

No description provided.

Error was:
`/usr/sbin/zfs-auto-snapshot: 207: /usr/sbin/zfs-auto-snapshot: Syntax error: redirection unexpected`
@stuehmer
Copy link
Contributor Author

I admit the /bin/bash change is a portabilty problem for the leecallan branch. However, before this workaround, the branch was broken using dash shell (e.g. on debian). I suggest while the script uses bash features we restrict the script to bash shell.

@highvoltage highvoltage merged commit 2940f44 into zfsonlinux:leecallen Apr 12, 2019
@rlaager
Copy link

rlaager commented Apr 12, 2019

@highvoltage What is this "leecallen" branch?

@stuehmer
Copy link
Contributor Author

It is a branch where the snapshot names (e.g. daily, weekly, ...) are NOT part of the snapshot file name together with the date but rather in a ZFS property. This way all snapshots can be managed more homogeneously purely by their date. This is necessary e.g. when exposing them to Samba as Shadow Copies.
(Nowadays Samba has provided some workarounds to ignore variable parts of the snapshot name but this is only available in newer Samba versions and can be fixed here just as well.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants