Set zfs-auto-snapshot to use UTC time for snapshots #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…correctly in Windows 7 Previous Versions.
dajhorn
added a commit
that referenced
this pull request
Jun 24, 2013
Set zfs-auto-snapshot to use UTC time for snapshots
Open
|
This pull changed the default timezone from local to UTC. I have created #77 which leaves the default as UTC but adds a program option |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into a bug when deploying this + Samba4 for Previous Versions to a Windows 7 client - all of the snapshots were appearing as 'Tomorrow'. It seems that Windows 7, at least, expects the date given to be in UTC. As I'm in UTC+8, this made all of the dates 8h ahead!
Just added the --utc flag to the date code there, and Windows 7 now correctly gives the date. This shouldn't affect anything else, since cron takes care of scheduling. UTC is also better idea to be storing the snapshot date in, as well.