This repository has been archived by the owner on Jan 21, 2020. It is now read-only.
Allow dash-separated keys #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per a number of reports, some modules were using dash-separated keys instead of underscore_separated keys for content-negotiation options. zf-content-negotiation was ignoring these previously, but starting with 1.2.0 and the introduction of the ContentNegotiationOptions class, these are now invalid and raise an exception, breaking applications. The specific module in question is likely zf-apigility-doctrine, and there's a PR against that repo to fix it: zfcampus/zf-apigility-doctrine#212. This patch modifies the options class to munge dash-separated values to ensure they work.
weierophinney
added a commit
that referenced
this pull request
Jul 16, 2015
|
Applied and tagged in both 1.0.9 and 1.1.1 |
|
zf-apigility-doctrine PR for this fix is zfcampus/zf-apigility-doctrine#213 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per a number of reports, some modules were using dash-separated keys instead of
underscore_separated keys for content-negotiation options.
zf-content-negotiation was ignoring these previously, but starting with 1.2.0
and the introduction of the ContentNegotiationOptions class, these are now
invalid and raise an exception, breaking applications.
The specific module in question is likely zf-apigility-doctrine, and there's a
PR against that repo to fix it: zfcampus/zf-apigility-doctrine#212.
This patch modifies the options class to munge dash-separated values to ensure
they work.