This repository was archived by the owner on Jan 21, 2020. It is now read-only.
ZF3 component compatibility #43
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Set minimum supported PHP version to 5.6 - Updated all component and module minimum supported versions to known stable versions; if v3 releases are available, supported via `||` constraints. - Expose module to zend-component-installer - Move `Module` class to `src/` tree, where it belongs, and: - Remove `getAutoloaderConfig()` - Remove direct interface implementations - Use `::class` notation
- Replaced `getMock()` usage with `getMockBuilder()->getMock()` - Use `::class` notation where possible
- trying to isolate a testing issue
weierophinney
force-pushed
the
feature/zf3compat
branch
from
1a8ed88 to
f651fea
Compare
- picks up michelf/markdown
- Added zend-inputfilter as a requirement. When `--prefer-lowest` is used, zend-mvc installs it, which is why tests passed, but when latest dependencies are installed, its absence causes tests to fail. - Ensured short array notation is used throughout. - Use `::class` notation wherever possible. - Extracted factory for `ApiFactory` into its own class, and removed `getServiceConfig()` implementation from `Module` class.
- Added missing LICENSE.md - Added Code Manifesto, CONDUCT.md - Updated CONTRIBUTING to refer to CONDUCT - Updated CONTRIBUTING to refer to composer scripts - Updated README to: - use short array notation - update the system config section to reflect recent changes - remove ZF2 verbiage - improve installation instructions
weierophinney
changed the title
25 tasks
|
Travis is evidently having a queueing problem. As such, I did the following locally:
In all cases, tests pass. As I've already been waiting 40 minutes for the build and have cancelled twice, I'm going to merge so I can move on to the swagger and apiblueprint updates. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch updates the module to be forwards compatible with v3 releases of Zend Framework components. Specifically, it does the following:
||constraints.Moduleclass to thesrc/tree, where it belongs, and:getAutoloaderConfig()implementation, as it was redundant.ApiFactoryfactory to its own class, allowing removal of thegetServiceConfig()implementation.