This repository has been archived by the owner on Jan 21, 2020. It is now read-only.
Fixed keys in content-negotiation Admin module #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correct keys used by other modules are underscore_separated. Here, was incorrectly, dash-separated so in configuration we had double keys. What's more dash-separated keys were red to populate forms in Apigility Admin. Also when both keys were present (dash-separated and underscore_separated) values were overridden in ContentNegotiationOptions.
michalbundyra
added a commit
that referenced
this pull request
Jan 17, 2018
Fixed keys in content-negotiation Admin module
michalbundyra
added a commit
that referenced
this pull request
Jan 17, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct keys used by other modules are underscore_separated.
Here, was incorrectly, dash-separated so in configuration we had double keys. What's more dash-separated keys were red to populate forms in Apigility Admin. Also when both keys were present (dash-separated and underscore_separated) values were overridden in
ContentNegotiationOptions.Noted in #288 and first reported in #209.
/cc @zfcampus/doctrine