This repository has been archived by the owner on Oct 26, 2023. It is now read-only.
fix unknown device name in command message #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Device names are retrieved by the configuration file. If an MQTT command is handled but contains an unknown device name, which is not in the configuration file an KeyError was thrown and the application was terminated. This commit checks if the device name is known, if not it logs an error message but will not fail.
|
I think it sounds reasonable, lets try this, thanks. |
|
Super :) thx |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Device names are retrieved by the configuration file. If an MQTT command is
handled but contains an unknown device name, which is not in the configuration
file a KeyError was thrown and the application was terminated. This commit
checks if the device name is known, if not it logs an error message but will not
fail.
Fixes KeyError exception #53
Type of change