Fix accessibility on modal #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the closing options dont have a label to it, also the overlay shouldn't be focusable as it just doubles the close button that comes beforehand. Therefor it also doesn't need the aria-label
|
✔️ Deploy Preview for css-ui ready! 🔨 Explore the source changes: 94c142e 🔍 Inspect the deploy log: https://app.netlify.com/sites/css-ui/deploys/620f9b7121a0b00008e8786d 😎 Browse the preview: https://deploy-preview-38--css-ui.netlify.app/docs/components/modal |
There was a problem hiding this comment.
Hi @Que-tin, thanks for your contribution. 👍
Please, could you update the modal template in the docs/ folder too?
|
Will do 👍🏻😊 |
Add the changes to the doc
|
Hi @zetareticoli done! 😊 |
|
I'll merge it on monday because it's a hotfix release. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the closing button doesn't have a label on it that can be accessed by screen readers, also the overlay shouldn't be focusable as it just doubles functionality of the close button that comes beforehand. Therefore that it has
tabindex=-1it also doesn't need the aria-label.