Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve validations for outbound nonces on zetaclient #2487

Closed
Tracked by #1965
kingpinXD opened this issue Jul 16, 2024 · 1 comment
Closed
Tracked by #1965

Improve validations for outbound nonces on zetaclient #2487

kingpinXD opened this issue Jul 16, 2024 · 1 comment
Labels
zetaclient Issues related to ZetaClient

Comments

@kingpinXD
Copy link
Contributor

kingpinXD commented Jul 16, 2024

Add a rule for outbound nonce verification to do the following

  • Fetch the address of the active tss when the transaction was created .
  • Verify that the sender is the correct TSS address

To fetch the address of the active TSS we have the following options

  • Use nonce : We can query pending nonces to find out the nonce range that is pending for a chain id, using the range and the nonce of the current cctx we can obtain the tss address that should have signed this outbound , and verify it .

  • Use TssPubkey : The Tss pubkey field is set when the outbound is created , we can derive the address from the pubkey and use that to verify the sender of the trasnaction

@kingpinXD kingpinXD added the zetaclient Issues related to ZetaClient label Jul 18, 2024
@kingpinXD
Copy link
Contributor Author

Related to #2664

Adding an index to the trackers would remove the need to have this change and its a much cleaner solution .

Closing this ticket for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
zetaclient Issues related to ZetaClient
Projects
None yet
Development

No branches or pull requests

1 participant