Update functionality table #722
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
You have run out of free Bugbot PR reviews for this billing cycle. This will reset on September 21. To receive Bugbot reviews on all of your PRs, please have a team admin upgrade your team to Bugbot Pro by visiting the Cursor dashboard. Your first 14 days will be free to try! |
📝 WalkthroughWalkthroughUpdated the per-network capability tables in src/pages/developers/chains/functionality.mdx for EVM, Solana, TON, and Sui to reflect new support statuses across Mainnet, Testnet, E2E, and Localnet. Several deposit/withdraw and call flows now show expanded support; certain no-asset-call and onRevert entries adjusted. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Pre-merge checks (2 passed, 1 warning)❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (9)
src/pages/developers/chains/functionality.mdx (9)
35-36: Confirm Solana “Withdraw and call” is live across all environmentsBoth native and fungible withdraw-and-call are now marked ✅ everywhere. Please confirm rollout status (program versions, relayer config) and add a short note or link to the corresponding how-to guide to reduce ambiguity.
41-43: Explain why Localnet is ❌ while E2E is ✅ for Solana no-asset calls/onRevertThis discrepancy will confuse readers. If Localnet lacks relayer or CPI plumbing, add a footnote. Otherwise, correct the table.
Proposed note to add right below the Solana table:
+> Note: On Localnet, no-asset calls and onRevert are disabled due to missing relayer components. Use E2E for these flows.
49-52: Clarify “fungible token” on SuiConsider specifying this refers to Sui coin types (not objects/NFTs) and link to the Sui integration guide to prevent misinterpretation.
58-58: Sui “No asset call to ZetaChain” shows E2E ❌ but Localnet ✅ — verifyUnusual that E2E lags Localnet. If inverted, please fix; if intentional, add a brief note (e.g., missing E2E runner support for Sui).
66-66: TON deposit/withdraw native coin marked fully ✅ — add constraints if anyIf limited to specific wallets/contracts or gateway versions, add a footnote to set expectations.
68-68: TON deposit-and-call (native) fully ✅ — reference exampleA link to the minimal example or guide would help readers reproduce successfully.
75-75: TON “No asset call to ZetaChain” Localnet ❌ — justify or correctDocument the reason (e.g., no relayer on Localnet) or align with actual support.
118-121: E2E definition points to Localnet; add a distinct Localnet term and fix E2E textCurrently “E2E” links to contrib/localnet, which is Localnet. Define both to avoid ambiguity.
Proposed edit to Terminology:
- **E2E** - The protocol level development environment - ([link](https://github.com/zeta-chain/node/tree/develop/contrib/localnet)). + **E2E** + Protocol-level end-to-end testing environment used for CI and internal validation. + + **Localnet** + Single/multi-node local environment for developers + ([link](https://github.com/zeta-chain/node/tree/develop/contrib/localnet)).
41-43: Normalize “Connected Chain” capitalization across tablesRow labels mix “connected chain” and “Connected Chain.” Align with the capitalized form used in Terminology.
Also applies to: 59-59, 101-103
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
src/pages/developers/chains/functionality.mdx(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: build
| | No asset call to ZetaChain | ✅ | ✅ | ✅ | ❌ | | ||
| | No asset call to connected chain | ✅ | ✅ | ✅ | ❌ | | ||
| | onRevert | ✅ | ✅ | ✅ | ❌ | |
There was a problem hiding this comment.
Do we have an issue to track on localnet?
| | Withdraw and call (native coin) | ❌ | ❌ | ❌ | ✅ | | ||
| | Withdraw and call (fungible token) | ❌ | ❌ | ❌ | ❌ | |
There was a problem hiding this comment.
Sui withdrawAndCall is enabled on testnet, though there will be breaking changes once we release authenticated call so we might not want to show it
Summary by CodeRabbit