[#3264]: Schema - Integration Field #3649
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
finnar-bin
approved these changes
Aug 4, 2025
agalin920
requested changes
Aug 7, 2025
| }, obj); | ||
| } | ||
|
|
||
| export const fetchApi = async <T = unknown>({ |
There was a problem hiding this comment.
I question the value of this abstraction, it’s mildly useful at best, but it introduces some questionable design choices that might hurt more than help.
Its a redundant abstraction and you lose flexibility without gaining much.
agalin920
requested changes
Aug 7, 2025
|
|
||
| const { endpoint, headers, type, keyPaths } = config; | ||
|
|
||
| const generateItemId = useCallback( |
There was a problem hiding this comment.
If this is really needed you could just use uuid library that we have instead of this complex logic.
Although I would ask you to question this further and see if this is really needed or if it can all be index based
agalin920
requested changes
Aug 7, 2025
| error, | ||
| children, | ||
| }: { | ||
| name?: string; |
There was a problem hiding this comment.
Use your standard prop typing pattern. FieldWrapperProps
| setType, | ||
| closeForm, | ||
| }: { | ||
| activeStep: number; |
There was a problem hiding this comment.
Same here regarding prop typing
agalin920
approved these changes
Aug 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technical Specs: https://docs.google.com/document/d/1xynOhoDtj6TJB_tUrvx_rPncL4sIT156TdPd3qlDaek/edit?usp=sharing
ADD FIELD:
Integration-Field-Add-Field.mp4
SELECT ITEMS:
Integration-Field-Select-Items.mp4