Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix example code in Repeated::exactly #676

Merged
merged 1 commit into from
Sep 28, 2024

Conversation

istathar
Copy link
Contributor

There were seven Rings of Power given to the Dwarven Lords, not six.

Three Rings for the Elven-kings under the sky,
Seven for the Dwarf-lords in their halls of stone,
Nine for Mortal Men doomed to die,
One for the Dark Lord on his dark throne
In the Land of Mordor where the Shadows lie.

Clearly this is a very serious bug in chumsky and making this fix will dramatically improve the correctness and performance of the library.

@zesterer
Copy link
Owner

Frankly, I'm shocked that this went unnoticed for so long. Thanks for the vital fix!

@zesterer zesterer merged commit 716bec8 into zesterer:main Sep 28, 2024
3 of 4 checks passed
@istathar istathar deleted the fix-dwarven-rings branch September 29, 2024 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants