Update Cargo.lock
#644
Closed
Update Cargo.lock
#644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why we manage Cargo.lock file in git |
|
@baoyachi I thought it was pretty well-accepted that lockfiles should be committed to version control, to make local development more deterministic? https://stackoverflow.com/a/44210813/5044950 But in any case, all I'm trying to do here is fix a tiny annoyance, nothing major. |
|
Thanks for the PR! @baoyachi that's traditionally been the case, yes: but the Rust project has recently changed guidance in favour of committing lockfiles for libraries. I'm personally still a bit ambivalent, but it does have advantages. |
|
I need to fix CI at some point. |
|
This has since been resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of commit ef9f20f, cloning and building the repo results in an extraneous diff on
Cargo.lock, which this PR fixes.