Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Webpages #36

Merged
merged 1 commit into from
Jun 24, 2023
Merged

Improve Webpages #36

merged 1 commit into from
Jun 24, 2023

Conversation

HimDek
Copy link
Contributor

@HimDek HimDek commented Jun 24, 2023

I was improving the polonium webpages. I hope you like it.

Highlights

  • All pages have a common header, footer and navbar.
  • Each individual page parses the corresponding markdown file that already exists and displays them.
  • Easy to extend.

View the page here.

The home page is unable to display the icon in my deployement because it uses the readme.md file from zeroxoneafour:master branch which is obviously unchanged. The icon will be visisble once this request is pulled.

@zeroxoneafour
Copy link
Owner

This looks incredible! Thank you so much for this redesign.

@zeroxoneafour zeroxoneafour merged commit d24fb0b into zeroxoneafour:master Jun 24, 2023
@HimDek
Copy link
Contributor Author

HimDek commented Jun 24, 2023

This looks incredible! Thank you so much for this redesign.

My pleasure. By the way, it seems you are using zeroxoneafour:stable branch for building the page which is why the changes are not deployed.

@zeroxoneafour
Copy link
Owner

I'm aware, I branched off stable so that the docs would be relevant to the version most users are using. I'll merge master back into it later tonight.

@HimDek
Copy link
Contributor Author

HimDek commented Jun 25, 2023

In that case, the master in the below line must be changed to the name of the branch you wish to deploy the page from.

fetch("https://raw.githubusercontent.com/zeroxoneafour/polonium/master/readme.md").then(function(response) {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants